Browse Source

Close the temporary file before re-opening it.

On Windows, we cannot reuse the temp.name to
reopen the file *unless* it has been closed
before [0].

This problem in turn made the `move_file`
request to fail, since the file was still
open at the time.

[0] https://docs.python.org/2/library/tempfile.html#tempfile.NamedTemporaryFile
pull/309/head
timotei 10 years ago
committed by William Ting
parent
commit
c889aa013e
1 changed files with 2 additions and 0 deletions
  1. +2
    -0
      bin/autojump_data.py

+ 2
- 0
bin/autojump_data.py View File

@ -121,6 +121,8 @@ def save(config, data):
try: try:
# write to temp file # write to temp file
temp = NamedTemporaryFile(delete=False) temp = NamedTemporaryFile(delete=False)
# prevent Windows errors by closing the file before opening it.
temp.close()
with open(temp.name, 'w', encoding='utf-8', errors='replace') as f: with open(temp.name, 'w', encoding='utf-8', errors='replace') as f:
for path, weight in data.items(): for path, weight in data.items():

Loading…
Cancel
Save