Explorar el Código

Remove warning about extraneous "ruby-" prefix in `.ruby-version`

When we started to support reading `.ruby-version` files, we made a
commitment to not support fuzzy version matching. Treating "ruby-2.1.5"
as "2.1.5" is a sort of fuzzy matching, so we put in place a warning
telling you to remove the extraneous "ruby-" prefix popularly used by
other Ruby version managers to denote MRI. (Their logic is that MRI is
"ruby" and other rubies are not "ruby", apparently.)

However, people are often not able to remove the prefix in their
projects because they want to support other coworkers and tools that
sadly still require the prefix, like RubyMine.

So to restore sanity for a big portion of our users, the warning is gone.
pull/360/head^2
Mislav Marohnić hace 11 años
padre
commit
6820704c91
Se han modificado 2 ficheros con 1 adiciones y 8 borrados
  1. +0
    -3
      libexec/rbenv-version-name
  2. +1
    -5
      test/version-name.bats

+ 0
- 3
libexec/rbenv-version-name Ver fichero

@ -21,9 +21,6 @@ version_exists() {
if version_exists "$RBENV_VERSION"; then if version_exists "$RBENV_VERSION"; then
echo "$RBENV_VERSION" echo "$RBENV_VERSION"
elif version_exists "${RBENV_VERSION#ruby-}"; then elif version_exists "${RBENV_VERSION#ruby-}"; then
{ echo "warning: ignoring extraneous \`ruby-' prefix in version \`${RBENV_VERSION}'"
echo " (set by $(rbenv-version-origin))"
} >&2
echo "${RBENV_VERSION#ruby-}" echo "${RBENV_VERSION#ruby-}"
else else
echo "rbenv: version \`$RBENV_VERSION' is not installed" >&2 echo "rbenv: version \`$RBENV_VERSION' is not installed" >&2

+ 1
- 5
test/version-name.bats Ver fichero

@ -57,9 +57,5 @@ setup() {
cat > ".ruby-version" <<<"ruby-1.8.7" cat > ".ruby-version" <<<"ruby-1.8.7"
run rbenv-version-name run rbenv-version-name
assert_success assert_success
assert_output <<OUT
warning: ignoring extraneous \`ruby-' prefix in version \`ruby-1.8.7'
(set by ${PWD}/.ruby-version)
1.8.7
OUT
assert_output "1.8.7"
} }

Cargando…
Cancelar
Guardar