Fix array declarator parsing

Refs https://github.com/atom/atom/issues/18346#issuecomment-433734281

corpus/declarations.txt

@@ -313,3 +313,22 @@ volatile int z = 7;
     (type_qualifier)
     (primitive_type)
     (init_declarator (identifier) (number_literal))))
+
+================================
+Local array declarations
+================================
+
+int main() {
+  char the_buffer[the_size];
+  char the_other_buffer[*];
+}
+
+---
+
+(translation_unit
+  (function_definition
+    (primitive_type)
+    (function_declarator (identifier) (parameter_list))
+    (compound_statement
+      (declaration (primitive_type) (array_declarator (identifier) (identifier)))
+      (declaration (primitive_type) (array_declarator (identifier))))))

grammar.js

@@ -216,29 +216,29 @@ module.exports = grammar({
     array_declarator: $ => prec(1, seq(
       $._declarator,
       '[',
-      optional($._declaration_specifiers),
-      optional($._expression),
+      repeat($.type_qualifier),
+      optional(choice($._expression, '*')),
       ']'
     )),
     array_field_declarator: $ => prec(1, seq(
       $._field_declarator,
       '[',
-      optional($._declaration_specifiers),
-      optional($._expression),
+      repeat($.type_qualifier),
+      optional(choice($._expression, '*')),
       ']'
     )),
     array_type_declarator: $ => prec(1, seq(
       $._type_declarator,
       '[',
-      optional($._declaration_specifiers),
-      optional($._expression),
+      repeat($.type_qualifier),
+      optional(choice($._expression, '*')),
       ']'
     )),
     abstract_array_declarator: $ => prec(1, seq(
       optional($._abstract_declarator),
       '[',
-      optional($._declaration_specifiers),
-      optional($._expression),
+      repeat($.type_qualifier),
+      optional(choice($._expression, '*')),
       ']'
     )),
 

src/grammar.json

@@ -1574,23 +1574,27 @@
             "value": "["
           },
           {
-            "type": "CHOICE",
-            "members": [
-              {
-                "type": "SYMBOL",
-                "name": "_declaration_specifiers"
-              },
-              {
-                "type": "BLANK"
-              }
-            ]
+            "type": "REPEAT",
+            "content": {
+              "type": "SYMBOL",
+              "name": "type_qualifier"
+            }
           },
           {
             "type": "CHOICE",
             "members": [
               {
-                "type": "SYMBOL",
-                "name": "_expression"
+                "type": "CHOICE",
+                "members": [
+                  {
+                    "type": "SYMBOL",
+                    "name": "_expression"
+                  },
+                  {
+                    "type": "STRING",
+                    "value": "*"
+                  }
+                ]
               },
               {
                 "type": "BLANK"
@@ -1619,23 +1623,27 @@
             "value": "["
           },
           {
-            "type": "CHOICE",
-            "members": [
-              {
-                "type": "SYMBOL",
-                "name": "_declaration_specifiers"
-              },
-              {
-                "type": "BLANK"
-              }
-            ]
+            "type": "REPEAT",
+            "content": {
+              "type": "SYMBOL",
+              "name": "type_qualifier"
+            }
           },
           {
             "type": "CHOICE",
             "members": [
               {
-                "type": "SYMBOL",
-                "name": "_expression"
+                "type": "CHOICE",
+                "members": [
+                  {
+                    "type": "SYMBOL",
+                    "name": "_expression"
+                  },
+                  {
+                    "type": "STRING",
+                    "value": "*"
+                  }
+                ]
               },
               {
                 "type": "BLANK"
@@ -1664,23 +1672,27 @@
             "value": "["
           },
           {
-            "type": "CHOICE",
-            "members": [
-              {
-                "type": "SYMBOL",
-                "name": "_declaration_specifiers"
-              },
-              {
-                "type": "BLANK"
-              }
-            ]
+            "type": "REPEAT",
+            "content": {
+              "type": "SYMBOL",
+              "name": "type_qualifier"
+            }
           },
           {
             "type": "CHOICE",
             "members": [
               {
-                "type": "SYMBOL",
-                "name": "_expression"
+                "type": "CHOICE",
+                "members": [
+                  {
+                    "type": "SYMBOL",
+                    "name": "_expression"
+                  },
+                  {
+                    "type": "STRING",
+                    "value": "*"
+                  }
+                ]
               },
               {
                 "type": "BLANK"
@@ -1717,23 +1729,27 @@
             "value": "["
           },
           {
-            "type": "CHOICE",
-            "members": [
-              {
-                "type": "SYMBOL",
-                "name": "_declaration_specifiers"
-              },
-              {
-                "type": "BLANK"
-              }
-            ]
+            "type": "REPEAT",
+            "content": {
+              "type": "SYMBOL",
+              "name": "type_qualifier"
+            }
           },
           {
             "type": "CHOICE",
             "members": [
               {
-                "type": "SYMBOL",
-                "name": "_expression"
+                "type": "CHOICE",
+                "members": [
+                  {
+                    "type": "SYMBOL",
+                    "name": "_expression"
+                  },
+                  {
+                    "type": "STRING",
+                    "value": "*"
+                  }
+                ]
               },
               {
                 "type": "BLANK"